Messages in this thread Patch in this message | | | From | "Rafael J. Wysocki" <> | Subject | [RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue | Date | Wed, 15 Sep 2010 21:56:30 +0200 |
| |
From: Rafael J. Wysocki <rjw@sisk.pl> Subject: PM / Runtime: Use alloc_workqueue() for creating PM workqueue
Although we need the PM workqueue to be freezable, we don't need it to be singlethread. Also, the number of concurrent work items running on a single CPU need not be constrained. For these reasons use alloc_workqueue() directly, with suitable arguments, instead of create_freezeable_workqueue(), to create the runtime PM workqueue.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> ---
Tejun,
I'm not sure about that WQ_RESCUER thing. Can you please tell me what exactly it is for?
Thanks, Rafael
--- kernel/power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/kernel/power/main.c =================================================================== --- linux-2.6.orig/kernel/power/main.c +++ linux-2.6/kernel/power/main.c @@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq); static int __init pm_start_workqueue(void) { - pm_wq = create_freezeable_workqueue("pm"); + pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE | WQ_RESCUER, 0); return pm_wq ? 0 : -ENOMEM; }
| |