Messages in this thread | | | Subject | Re: [PATCH 00/15] change default_llseek action | From | Valdis.Kletnieks@vt ... | Date | Wed, 15 Sep 2010 11:38:56 -0400 |
| |
On Tue, 14 Sep 2010 22:22:28 +0200, Arnd Bergmann said:
> This changes *all* instances of struct file_operations in > the kernel to have a .llseek operation and then changes > the default to no_llseek, which returns -ESPIPE, which > is what we had decided some time ago in a discussion > with Christoph Hellwig.
I don't suppose there's any clean way to throw a build error or a printk_on_once() or something if we encounter an unconverted 'struct file_operations', is there? I have this creeping fear that this patch will go upstream during the merge window - as will 12 new staging/ drivers from authors who didn't get the memo yet.
Other than the "missed converting a new usage" issue, it looks OK to me.
[unhandled content-type:application/pgp-signature] | |