lkml.org 
[lkml]   [2010]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] SLUB: Mark merged slab caches in /proc/slabinfo
I didn't see this before I replied to the 1/2 patch..

On Tue, Sep 14, 2010 at 10:59 AM, Pekka Enberg <penberg@kernel.org> wrote:
> On Tue, 14 Sep 2010, Pekka Enberg wrote:
>>> Unfortunately this breaks "slabtop". I guess we could try some other delimiter?
>
> On Tue, Sep 14, 2010 at 8:28 PM, Christoph Lameter <cl@linux.com> wrote:
>> + ?
>
> Looking at procps sources, slabtop and other utilities seem to think
> slab cache names are limited to 64 bytes. Linus, are you OK with
> adding a "+" character prefix for merged caches like you suggested in
> private?

I'd much rather see "x+y+z" and actually see what the slab entries are.

But we can certainly also say "limit it to 64 bytes" and truncate
things past that.

Linus


\
 
 \ /
  Last update: 2010-09-14 20:09    [W:0.059 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site