lkml.org 
[lkml]   [2010]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] sched: fix user time incorrectly accounted as system time on 32 bit
From
Date
On Tue, 2010-09-14 at 16:35 +0200, Stanislaw Gruszka wrote:
> We have 32 bit variable overflow possibility when multiply in
> task_times() and thread_group_times() functions. If overflow happens
> calculated scaled utime value become wrongly small and scaled stime
> wrongly big.

Ah, right, (u64)foo * bar would have worked too I guess, but yeah, the
used (u64)(foo * bar) is wrong.

> Reported here:
> https://bugzilla.redhat.com/show_bug.cgi?id=633037
> https://bugzilla.kernel.org/show_bug.cgi?id=16559
>
> Reported-by: Michael Chapman <redhat-bugzilla@very.puzzling.org>
> Reported-by: Ciriaco Garcia de Celis <sysman@etherpilot.com>
> Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: <stable@kernel.org> # 2.6.32.19+ (partially) and 2.6.33+
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>

Thanks, got it.


\
 
 \ /
  Last update: 2010-09-14 16:41    [W:0.029 / U:18.692 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site