lkml.org 
[lkml]   [2010]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL 0/1] perf/core ui browser improvement

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, 2010-09-13 at 18:29 -0300, Arnaldo Carvalho de Melo wrote:
> > + 3.00% find [kernel.kallsyms] [k] n_tty_write
>
> > + 3.00% find kernel k n_tty_write
>
> I find that [k] is visually easier to separate from the symbol name.

me too. Something like:

before:

1.08% cc1 libc-2.12.so [.] _int_malloc
0.94% cc1 [kernel.kallsyms] [k] clear_page_c
0.74% cc1 libc-2.12.so [.] _int_free
0.69% cc1 [kernel.kallsyms] [k] page_fault
0.46% cc1 libc-2.12.so [.] malloc_consolidate

after:

1.08% cc1 # libc-2.12.so [.] _int_malloc
0.94% cc1 # kernel [k] clear_page_c
0.74% cc1 # libc-2.12.so [.] _int_free
0.69% cc1 # kernel [k] page_fault
0.46% cc1 # libc-2.12.so [.] malloc_consolidate


Would largely do the trick i think. The comments delineate the DSO
portion from the task portion nicely - while also being a familar
pattern. The column of [.] and [k] gives kernel developers a quick
glance wrt. whether it's kernel or user-space - and it also delineates
the symbol column from the DSO column.

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-09-14 14:19    [from the cache]
©2003-2011 Jasper Spaans