Messages in this thread |  | | | From | "Tomoya MORINAGA" <> | | Subject | Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35 | | Date | Tue, 14 Sep 2010 11:52:30 +0900 |
| |
----- Original Message ----- From: "Grant Likely" <grant.likely@secretlab.ca> To: "Linus Walleij" <linus.ml.walleij@gmail.com> Cc: "Masayuki Ohtake" <masa-korg@dsn.okisemi.com>; <meego-dev@meego.com>; "LKML" <linux-kernel@vger.kernel.org>; "David Brownell" <dbrownell@users.sourceforge.net>; <qi.wang@intel.com>; <yong.y.wang@intel.com>; <andrew.chih.howe.khor@intel.com>; <arjan@linux.intel.com>; <gregkh@suse.de>; "Tomoya MORINAGA" <morinaga526@dsn.okisemi.com>; "Thomas Gleixner" <tglx@linutronix.de>; "David Woodhouse" <dwmw2@infradead.org> Sent: Friday, September 10, 2010 1:55 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35
> On Thu, Sep 09, 2010 at 10:58:38PM +0200, Linus Walleij wrote: > > 2010/9/3 Masayuki Ohtake <masa-korg@dsn.okisemi.com>: > > > > > Each instance of our SPI device has the same vendor ID and device ID. > > > Thus, I think it is impossible to be called probe() for each instance. > > > > Looking at you latest patch it appears you could :-) > > That solves the problem pretty nicely. > > Actually, it doesn't look like he did. It looks to me that the > ability to support multiple spi bus instances on a single PCI device > has simply been removed. I don't know if that is because it simply > isn't needed yet, or if it is because Ohtake-san doesn't quite > understand what were suggesting.
We wanted you to accept multi-instance the SPI patch. But seeing maintainer's comments, I felt it is difficult to be accepted. Thus, I have deleted whole of multi-instance code.
> > Regardless it doesn't matter. When or if the driver does need to be > modified to support multiple instances, it is a relatively straight > forward matter to refactor the current code into a platform_driver, > and create a new pci_driver that simply registers the matching > platform_device for each spi bus instance supported by the device. > > g. >
|  |