lkml.org 
[lkml]   [2010]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
    Date
    Dne Po 13. září 2010 07:34:36 Haojian Zhuang napsal(a):
    > On Mon, Sep 13, 2010 at 11:51 AM, Mark F. Brown <mark.brown314@gmail.com>
    wrote:
    > > Defined I2C/ALARM pin definitions
    > > DS1337 RTC alarm support is tied to RTC_INT_GPIO
    > >
    > > Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
    > > ---
    > > arch/arm/mach-mmp/teton_bga.c | 16 ++++++++++++++++
    > > 1 files changed, 16 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/arch/arm/mach-mmp/teton_bga.c
    > > b/arch/arm/mach-mmp/teton_bga.c index 2966117..d631bbc 100644
    > > --- a/arch/arm/mach-mmp/teton_bga.c
    > > +++ b/arch/arm/mach-mmp/teton_bga.c
    > > @@ -18,6 +18,7 @@
    > > #include <linux/gpio.h>
    > > #include <linux/input.h>
    > > #include <plat/pxa27x_keypad.h>
    > > +#include <linux/i2c.h>
    > >
    > > #include <asm/mach-types.h>
    > > #include <asm/mach/arch.h>
    > > @@ -38,6 +39,13 @@ static unsigned long teton_bga_pin_config[] __initdata
    > > = { GPIO110_KP_MKIN0,
    > > GPIO111_KP_MKOUT7,
    > > GPIO112_KP_MKOUT6,
    > > +
    > > + /* I2C Bus */
    > > + GPIO105_CI2C_SDA,
    > > + GPIO106_CI2C_SCL,
    > > +
    > > + /* RTC */
    > > + GPIO78_GPIO,
    > > };
    > >
    > > static unsigned int teton_bga_matrix_key_map[] = {
    > > @@ -55,6 +63,13 @@ static struct pxa27x_keypad_platform_data
    > > teton_bga_keypad_info __initdata = { .debounce_interval = 30,
    > > };
    > >
    > > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
    > > + {
    > > + I2C_BOARD_INFO("ds1337", 0x68),
    > > + .irq = gpio_to_irq(RTC_INT_GPIO)
    > > + },
    > > +};
    > > +
    > > static void __init teton_bga_init(void)
    > > {
    > > mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
    > > @@ -62,6 +77,7 @@ static void __init teton_bga_init(void)
    > > /* on-chip devices */
    > > pxa168_add_uart(1);
    > > pxa168_add_keypad(&teton_bga_keypad_info);
    > > + pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
    > > }
    > >
    > > MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
    > > --
    > > 1.7.0.4
    > >
    > > --
    > > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
    > > in the body of a message to majordomo@vger.kernel.org
    > > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > > Please read the FAQ at http://www.tux.org/lkml/
    >
    > Acked

    Yes, they look good:

    Acked-by: Marek Vasut <marek.vasut@gmail.com>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-13 09:47    [W:0.040 / U:29.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site