Messages in this thread |  | | | Date | Mon, 13 Sep 2010 19:51:30 +0400 | | From | Sergei Shtylyov <> | | Subject | Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over |
| |
Hello.
Ming Lei wrote:
>> But why not modify the conditional above all that code, just excluding >> 'is_dma' from it. This conditional already includes (request->actual == >> request->length) check. Please recast this patch.
> The two condition is OR relation, not and, so we can't exclude 'is_dma' simply.
Yes, we can. You're clearly handling only the DMA case with your added check, the PIO case was already handled.
> Anyway, the change is not wrong, right?
Not wrong, but the check is duplicate.
> thanks,
WBR, Sergei
|  |