Messages in this thread | | | Date | Sun, 12 Sep 2010 19:26:10 +0530 | Subject | Re: [PATCH] Btrfs: Remove useless condition | From | Jaswinder Singh Rajput <> |
| |
Hello,
On Sun, Sep 12, 2010 at 5:59 PM, Johannes Weiner <hannes@cmpxchg.org> wrote: > On Sun, Sep 12, 2010 at 04:32:20PM +0530, Jaswinder Singh Rajput wrote: >> >> if (ret) is useless as it will be never NULL as in previous statement >> we are setting ret = prev for !ret > > If there is no match and no extent below the given file offset, `prev' > will be NULL as well, no? > > So the check is not useless, it prevents throwing out a cached success > in case of a lookup failure. >
Got it !!
Thanks, -- Jaswinder Singh.
| |