lkml.org 
[lkml]   [2010]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] ACPI: apei: Cast u64 to unsigned long, fix compile warning
    From
    Date
    In today linux-net I got a compile warning in acpi/apei

    drivers/acpi/apei/erst.c: In function ‘erst_exec_move_data’:
    drivers/acpi/apei/erst.c:273: warning: cast to pointer from integer of different size
    drivers/acpi/apei/erst.c:274: warning: cast to pointer from integer of different size

    The problem is that apei_exec_context->dst_base type is u64.
    But in 32 bits architecture void * is 32 bits long.
    Casting it to unsigned long solves the issue

    Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
    ---
    drivers/acpi/apei/erst.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
    index a4904f1..37d7a05 100644
    --- a/drivers/acpi/apei/erst.c
    +++ b/drivers/acpi/apei/erst.c
    @@ -270,8 +270,8 @@ static int erst_exec_move_data(struct apei_exec_context *ctx,
    rc = __apei_exec_read_register(entry, &offset);
    if (rc)
    return rc;
    - memmove((void *)ctx->dst_base + offset,
    - (void *)ctx->src_base + offset,
    + memmove((void *)(unsigned long)ctx->dst_base + offset,
    + (void *)(unsigned long)ctx->src_base + offset,
    ctx->var2);

    return 0;
    --
    1.7.0.4


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-12 15:51    [W:0.026 / U:0.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site