Messages in this thread |  | | | Subject | Re: [RFC 5/6] x86, NMI, Add support to notify hardware error with unknown NMI | | From | Huang Ying <> | | Date | Mon, 13 Sep 2010 10:19:49 +0800 |
| |
On Sat, 2010-09-11 at 02:40 +0800, Don Zickus wrote: > On Fri, Sep 10, 2010 at 06:19:29PM +0200, Andi Kleen wrote: > > > > > I am grasping for straws here, but is there a register that APEI/HEST > > > can poke to see if it generated the NMI? > > > > HEST knows this yes. > > > > But this is not about HEST errors, but about those without HEST > > handling. > > Don't most unknown NMIs fall into the same boat, that they were not being > handled properly?
As far as I know, at least on some platforms, unknown NMIs are used for hardware error reporting. They will cause "Blue Screen" in Windows.
> On the other hand could you use the die_notifier_chain(DIE_UNKNOWNNMI) for > the same purpose and keep the unknown_nmi_error() handler a little > cleaner?
I think explicit function call has better readability than notifier chain.
Best Regards, Huang Ying
|  |