lkml.org 
[lkml]   [2010]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/17] writeback: quit throttling when signal pending
On Mon, Sep 13, 2010 at 04:46:54AM +0800, Neil Brown wrote:
> On Sun, 12 Sep 2010 23:49:50 +0800
> Wu Fengguang <fengguang.wu@intel.com> wrote:
>
> > This allows quick response to Ctrl-C etc. for impatient users.
> >
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> > ---
> > mm/page-writeback.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > --- linux-next.orig/mm/page-writeback.c 2010-09-09 16:01:14.000000000 +0800
> > +++ linux-next/mm/page-writeback.c 2010-09-09 16:02:27.000000000 +0800
> > @@ -553,6 +553,9 @@ static void balance_dirty_pages(struct a
> > __set_current_state(TASK_INTERRUPTIBLE);
> > io_schedule_timeout(pause);
> >
> > + if (signal_pending(current))
> > + break;
> > +
>
> Given the patch description, I think you might want "fatal_signal_pending()"
> here ???

__fatal_signal_pending() tests SIGKILL only, while the one often used
and need more quick responding is SIGINT..

Thanks,
Fengguang


\
 
 \ /
  Last update: 2010-09-13 03:57    [W:0.104 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site