Messages in this thread | | | Date | Sun, 12 Sep 2010 22:52:49 +0200 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: keucr: check kmalloc() return value |
| |
On Sun, Sep 12, 2010 at 10:56:43PM +0400, Vasiliy Kulikov wrote: > kmalloc() may fail, if so return error code. > Also don't alloc 16 bytes from the heap, use stack instead.
I don't have ENE_SendScsiCmd() in my repo, but I think it's a DMA function. You're not supposed to use stack memory for DMA transfers. This is documented in: Documentation/DMA-API-HOWTO.txt
So the original code is correct here (except that there is no error handling).
regards, dan carpenter
| |