lkml.org 
[lkml]   [2010]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: bna: potential null dereference
From
From: Jiri Slaby <jirislaby@gmail.com>
Date: Sat, 04 Sep 2010 14:59:54 +0200

> stanse found a potential null dereference:
> bnad_cb_tx_cleanup
> -> struct bnad_unmap_q *unmap_q = tcb->unmap_q;
> -> -- tcb cannot be null now --
> -> if (!tcb || (!tcb->unmap_q))
>
> The thing is I have no idea whether the second parameter of cleanup may
> be null (move assignment after the check) or not (remove the check)
>
> Could you fix that?

Since the Brocade folks can't be bothered to fix this for more than
a week I'll take care of this, thanks Jiri.


\
 
 \ /
  Last update: 2010-09-12 21:05    [W:0.044 / U:9.492 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site