Messages in this thread | | | Date | Fri, 10 Sep 2010 23:50:22 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer |
| |
On Fri, 10 Sep 2010 10:19:24 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi > <n-horiguchi@ah.jp.nec.com> wrote: > > This patch applies Andrea's fix given by the following patch into > > hugepage rmapping code: > > > > commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05 > > Author: Andrea Arcangeli <aarcange@redhat.com> > > Date: Mon Aug 9 17:19:09 2010 -0700 > > > > This patch uses anon_vma->root and avoids unnecessary overwriting > > when anon_vma is already set up. > > Btw, why isn't the code in __page_set_anon_rmap() also doing this > cleaner version (ie a single "if (PageAnon(page)) return;" up front)?
Perhaps I misunderstand the question, but __page_set_anon_rmap should handle Anon pages, shouldn't it?
> > The comments in that function are also some alien language translated > to english by some broken automatic translation service. Could > somebody clean up that function and come up with a comment that > actually parses as English and makes sense?
I'll do that.
-Andi
-- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |