lkml.org 
[lkml]   [2010]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] x86, tsc: Fix a preemption leak in restore_sched_clock_state()
    From
    Date

    D'0h !! *facepalm*

    Shame on me for not spotting that sooner.

    ---
    Subject: x86, tsc: Fix a preemption leak in restore_sched_clock_state()

    A real life genuine preemption leak..

    Reported-by: Jeff Chua <jeff.chua.linux@gmail.com>
    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    ---
    arch/x86/kernel/tsc.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
    index 873a321..4496315 100644
    --- a/arch/x86/kernel/tsc.c
    +++ b/arch/x86/kernel/tsc.c
    @@ -655,7 +655,7 @@ void restore_sched_clock_state(void)

    local_irq_save(flags);

    - get_cpu_var(cyc2ns_offset) = 0;
    + __get_cpu_var(cyc2ns_offset) = 0;
    offset = cyc2ns_suspend - sched_clock();

    for_each_possible_cpu(cpu)


    \
     
     \ /
      Last update: 2010-09-10 22:35    [W:0.020 / U:31.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site