lkml.org 
[lkml]   [2010]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: SV: SV: [PATCH 2/3] MFD: AB8500 debugfs
On Fri, Sep 10, 2010 at 08:27:38PM +0200, Mattias WALLIN wrote:

Please fix your mail client to word wrap within paragraphs.

> >Pretty much; probably needs to be slightly more involved than that to
> >make sure the selection lines up with the core but certainly the same
> >effect for users.

> Sorry I don't follow.

If CONFIG_DEBUG_FS=y but the chip core is built as a module your
suggested change would try to build the debugfs code into the kernel
linking against symbols defined in the module.

> But after thinking about it I realize that only changing the Makefile
> is not a good idea

> I need ifdefs in the .c file for avoiding build problems. Isn't the
> first solution with Kconfig better?

I don't see what relevance of these two points to each other? You can
check for CONFIG_DEBUG_FS just as easily as for the new Kconfig symbol
you added. No matter what you do you need ifdefs in the code.


\
 
 \ /
  Last update: 2010-09-10 20:45    [W:0.048 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site