Messages in this thread | | | Subject | Re: [PATCH 2/3] mmc_test: change simple_strtol() to strict_strtol() | From | Andy Shevchenko <> | Date | Wed, 01 Sep 2010 11:43:25 +0300 |
| |
On Wed, 2010-09-01 at 10:25 +0200, Quadros Roger (Nokia-MS/Helsinki) wrote:
> No patch summary? Will be in next version.
> > -static void mmc_test_run(struct mmc_test_card *test, int testcase) > > +static void mmc_test_run(struct mmc_test_card *test, long testcase) > > { > > - int i, ret; > > + long i; > > Why this change? isn't unsigned int sufficient for the mmc test cases? You are right. This certain change is redundant. I'll skip it.
> > - testcase = simple_strtol(buf, NULL, 10); > > + if (strict_strtol(buf, 10,&testcase)) > space required ^ here It's odd. I have space in my patch.
-- With Best Regards, Andy Shevchenko
| |