Messages in this thread | | | Date | Wed, 01 Sep 2010 14:46:58 -0700 (PDT) | Subject | Re: [PATCH net-next-2.6] net/ipv4: push IP options to CB in ip_fragment | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 31 Aug 2010 07:20:31 +0200
> We could have a padding in front of struct br_input_skb_cb to make sure > we dont overwrite IP (4|6) CB in bridge ? > > Something like this untested patch :
This will not help Brandan's case.
His packets are coming straight from TUN/TAP. They did not live in the IP stack at all before hitting the bridge and then heading to ip_fragment().
Therefore I'm inclined to agree with Herbert that we need to parse the options explicitly before invoke ip_fragment(). We must call it with an SKB in the state it expects, and that means with options parsing already performed.
| |