Messages in this thread | | | Date | Wed, 1 Sep 2010 17:30:27 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/5] block: make __blk_rq_prep_clone() copy most command flags |
| |
On Mon, Aug 30, 2010 at 11:58:12AM +0200, Tejun Heo wrote: > Currently __blk_rq_prep_clone() copies only REQ_WRITE and REQ_DISCARD. > There's no reason to omit other command flags and REQ_FUA needs to be > copied to implement FUA support in request-based dm. > > REQ_COMMON_MASK which specifies flags to be copied from bio to request > already identifies all the command flags. Define REQ_CLONE_MASK to be > the same as REQ_COMMON_MASK for clarity and make __blk_rq_prep_clone() > copy all flags in the mask. > > Signed-off-by: Tejun Heo <tj@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |