lkml.org 
[lkml]   [2010]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] kbuild: fix oldnoconfig to do the right thing
    From: Kyle McMartin <kyle@redhat.com>

    Commit 861b4ea4 broke oldnoconfig when removed the oldnoconfig checks on
    if (input_mode == nonint_oldconfig ||
    input_mode == oldnoconfig) {
    if (input_mode == nonint_oldconfig &&
    sym->name &&
    !sym_is_choice_value(sym)) {
    to avoid oldnoconfig chugging through the else stanza.

    Fix that to restore expected behaviour (which I've confirmed in the
    Fedora kernel build that the configs end up looking the same.)

    Signed-off-by: Kyle McMartin <kyle@redhat.com>
    ---
    diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
    index 5b7c86e..7ef429c 100644
    --- a/scripts/kconfig/conf.c
    +++ b/scripts/kconfig/conf.c
    @@ -427,7 +427,7 @@ static void check_conf(struct menu *menu)
    if (sym->name && !sym_is_choice_value(sym)) {
    printf("CONFIG_%s\n", sym->name);
    }
    - } else {
    + } else if (input_mode != oldnoconfig) {
    if (!conf_cnt++)
    printf(_("*\n* Restart config...\n*\n"));
    rootEntry = menu_get_parent_menu(menu);

    \
     
     \ /
      Last update: 2010-09-01 17:23    [W:0.042 / U:60.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site