lkml.org 
[lkml]   [2010]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
Hi Axel,

On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> The i2c_client received in probe() should not be kfree()'d.
This should go through Liam's tree, I'm CC'ing him to this thread.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/max8998.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 0d68de2..73e6f5c 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
> int ret = 0;
>
> max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
> - if (max8998 == NULL) {
> - kfree(i2c);
> + if (max8998 == NULL)
> return -ENOMEM;
> - }
>
> i2c_set_clientdata(i2c, max8998);
> max8998->dev = &i2c->dev;
> --
> 1.5.4.3
>
>
>

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2010-08-09 11:17    [W:0.053 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site