lkml.org 
[lkml]   [2010]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: gpio-addr-flash warnings on x86/highmem (Re: i386 allmodconfig, current mainline)
On Mon, 9 Aug 2010 19:52:35 -0400
Mike Frysinger <vapier.adi@gmail.com> wrote:

> On Mon, Aug 9, 2010 at 19:43, Andrew Morton wrote:
> > Guys. __What's goin' on out there?
> >
> > drivers/mtd/maps/gpio-addr-flash.c: In function 'gpio_flash_probe':
> > drivers/mtd/maps/gpio-addr-flash.c:212: warning: cast to pointer from integer of different size
> > drivers/mtd/maps/gpio-addr-flash.c:224: warning: cast to pointer from integer of different size
>
> i did get a bug report about this in the past, but honestly i havent
> gotten around to fixing the issues. it's been low priority as my
> understanding is that the warning shows up in configurations where the
> driver isnt realistically usable. not making excuses, just laying out
> the reality of things.

Casting a resource_size_t to a kernel pointer is plain naughty.

I guess an acceptable "fix" would be to disable to offending combinations
in Kconfig and add a

BUILD_BUG_ON(sizeof(gpios->start) != sizeof(void *))

to catch stragglers.

But please do fix warnings, if only because the warning storm from
allmodconfig causes people to miss important warnings in all the noise.


\
 
 \ /
  Last update: 2010-08-10 02:09    [W:0.039 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site