Messages in this thread | | | Subject | Re: [PATCH] x86: remove __phys_reloc_hide | From | Namhyung Kim <> | Date | Mon, 09 Aug 2010 15:40:31 +0900 |
| |
2010-08-09 (월), 08:22 +0200, Andi Kleen:
> It's for the benefit of the compiler, we've had miscompilations > due to undefined overflow for addresses in the past. The optimizer > assumes this won't happen. > > Given the x86-64 version normally doesn't overflow, but it's > still safer to have it. > > -Andi >
Hi,
I'm not talking about the RELOC_HIDE itself. I do know we need it for some specific case, ie. percpu. But in this case __pa_symbol(x) is expanded to RELOC_HIDE((unsigned long)(x), 0) which does nothing meaningful. I believe the overflow is not a concern here.
-- Regards, Namhyung Kim
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |