lkml.org 
[lkml]   [2010]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed
    On Mon, Aug 09, 2010 at 11:49:27PM +0400, Kulikov Vasiliy wrote:
    > @@ -2564,8 +2564,11 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
    > /* vector */
    > ioaddress = pci_resource_start(pdev, 3);
    > retval = pci_request_region(pdev, 3, "mxser(vector)");
    > - if (retval)
    > - goto err_relio;
    > + if (retval) {
    > + pci_release_region(pdev, 2);
    > + brd->info = NULL;
    > + goto err_release;

    This should just be goto err_null. The original err_null had a bug that
    it didn't call pci_release_region(pdev, 2); but you already fixed that.

    regards,
    dan carpenter

    > + }
    > brd->vector = ioaddress;
    >
    > /* irq */
    > @@ -2616,10 +2619,13 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
    > pci_set_drvdata(pdev, brd);
    >
    > return 0;
    > -err_relio:
    > - pci_release_region(pdev, 2);
    > err_null:
    > brd->info = NULL;
    > + pci_release_region(pdev, 2);
    > +err_release:
    > + pci_release_region(pdev, 3);
    > +err_disable:
    > + pci_disable_device(pdev);
    > err:
    > return retval;
    > #else



    \
     
     \ /
      Last update: 2010-08-09 22:31    [W:0.023 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site