lkml.org 
[lkml]   [2010]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier
From
Date
On Mon, 2010-08-09 at 02:36 -0700, Tejun Heo wrote:
> Commit 6ee0578b (workqueue: mark init_workqueues as early_initcall)
> made workqueue SMP initialization depend on workqueue_cpu_callback(),
> which however was registered as hotcpu_notifier() and didn't get
> called if CONFIG_HOTPLUG_CPU is not set. This made gcwqs on non-boot
> CPUs not create their initial workers leading to boot failures. Fix
> it by making it a cpu_notifier.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-and-bisected-by: walt <w41ter@gmail.com>
> ---
> So, something like this. Can you please verify the fix?
>
> Thanks.
>
> kernel/workqueue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index da6c482..2994a0e 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3527,7 +3527,7 @@ static int __init init_workqueues(void)
> unsigned int cpu;
> int i;
>
> - hotcpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);
> + cpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);
>
> /* initialize gcwqs */
> for_each_gcwq_cpu(cpu) {

Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>



\
 
 \ /
  Last update: 2010-08-09 19:11    [W:0.058 / U:24.492 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site