Messages in this thread | | | Date | Mon, 09 Aug 2010 06:56:40 -0700 | From | walt <> | Subject | Re: [PATCH wq#for-linus] workqueue: workqueue_cpu_callback() should be cpu_notifier not hotcpu_notifier |
| |
On 08/09/2010 02:36 AM, Tejun Heo wrote: > Commit 6ee0578b (workqueue: mark init_workqueues as early_initcall) > made workqueue SMP initialization depend on workqueue_cpu_callback(), > which however was registered as hotcpu_notifier() and didn't get > called if CONFIG_HOTPLUG_CPU is not set. This made gcwqs on non-boot > CPUs not create their initial workers leading to boot failures. Fix > it by making it a cpu_notifier. > --- > So, something like this. Can you please verify the fix?
> > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index da6c482..2994a0e 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -3527,7 +3527,7 @@ static int __init init_workqueues(void) > unsigned int cpu; > int i; > > - hotcpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE); > + cpu_notifier(workqueue_cpu_callback, CPU_PRI_WORKQUEUE);
This fixes the hang during boot for me too, thanks.
| |