lkml.org 
[lkml]   [2010]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] [BUGFIX] perf probe: Fix to copy the type for raw parameters
Masami Hiramatsu wrote:
> Copy type field if it is for raw parameters.
> Without this fix, perf probe drops the type if user passes it
> for raw parameters (e.g. %ax:u32 will be converted to %ax).

Hi Arnaldo,

Could you pick these patches?

Thank you,

>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>
> tools/perf/util/probe-finder.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 840f1aa..b69d194 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -706,8 +706,12 @@ static int find_variable(Dwarf_Die *sp_die, struct probe_finder *pf)
> pf->tvar->value = strdup(pf->pvar->var);
> if (pf->tvar->value == NULL)
> return -ENOMEM;
> - else
> - return 0;
> + if (pf->pvar->type) {
> + pf->tvar->type = strdup(pf->pvar->type);
> + if (pf->tvar->type == NULL)
> + return -ENOMEM;
> + }
> + return 0;
> }
>
> pr_debug("Searching '%s' variable in context.\n",
>
>



\
 
 \ /
  Last update: 2010-08-06 09:21    [W:0.293 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site