lkml.org 
[lkml]   [2010]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Stable-review] [26/34] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition
Date


In message <20100806210619.GA5863@suse.de> you wrote:
> On Fri, Aug 06, 2010 at 09:53:17PM +0100, Ben Hutchings wrote:
> > On Fri, 2010-08-06 at 11:57 -0700, Greg KH wrote:
> > > 2.6.32-stable review patch. If anyone has any objections, please let us
know.
> > >
> > > ------------------
> > > [stable] [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in ci
fs_init_dns_resolver() definition
> > >
> > > From: Michael Neuling <mikey@neuling.org>
> > >
> > > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this erro
r
> > >
> > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attr
ibute__' before 'cifs_init_dns_resolver'
> > >
> > > This adds the correct header file to fix this.
> > [...]
> >
> > Why <linux/module.h> and not <linux/init.h>?
>
> Heh, it works :)
>
> Michael?

It's what David Howells wanted.....
http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-08/msg01316.html
(below as well)


> An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
>
> fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
>
> This removes the __init from cifs_init_dns_resolver()

That's not really a good idea as the assembler may choose different pieces of
assembly to do variable references and jumps, depending on the section
information.

A better fix is to add:

#include <linux/module.h>

to the header file.

David



\
 
 \ /
  Last update: 2010-08-07 05:41    [from the cache]
©2003-2011 Jasper Spaans