lkml.org 
[lkml]   [2010]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells
    From
    On Fri, Aug 6, 2010 at 10:54 AM, Dan Williams <dan.j.williams@intel.com> wrote:
    > On Thu, Aug 5, 2010 at 12:30 AM, Linus Walleij
    > <linus.ml.walleij@gmail.com> wrote:
    >> 2010/8/5 Alessandro Rubini <rubini@unipv.it>:
    >>
    >>>> Peter, Alessandro and Viresh especially: you will hopefully use this
    >>>> driver for ARM refboards, Nomadik and SPEAr, can you provide
    >>>> an Acked-by:?
    >>>
    >>> I'm sorry I can't test it these times, I must delay stuff to
    >>> the last week of August.
    >>
    >> That's be a Tested-by: tag, Acked-by: was more about whether you
    >> think it looks sane I believe, see Documentation/SubmittingPatches.
    >
    > We have the Acked-by from Viresh, Alessandro looks like he is
    > interested in trying it out, the driver is self contained, marked
    > experimental, and you have a track-record of fixing things up, so I'll
    > include it with the idea it will be easier to fixup in-tree.

    ...except this version no longer compiles:

    drivers/dma/amba-pl08x.c: In function 'dma_set_runtime_config':
    drivers/dma/amba-pl08x.c:1399: error: 'struct dma_slave_config' has no
    member named 'maxburst'
    drivers/dma/amba-pl08x.c:1405: error: 'struct dma_slave_config' has no
    member named 'addr'
    drivers/dma/amba-pl08x.c:1408: error: 'struct dma_slave_config' has no
    member named 'addr_width'
    drivers/dma/amba-pl08x.c:1464: error: 'struct dma_slave_config' has no
    member named 'addr_width'
    drivers/dma/amba-pl08x.c:1464: error: 'struct dma_slave_config' has no
    member named 'maxburst'

    Fix that up and we can try to get it in the second half of the merge window.

    --
    Dan


    \
     
     \ /
      Last update: 2010-08-06 20:37    [W:0.020 / U:210.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site