lkml.org 
[lkml]   [2010]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/10] perf timechart: Adjust confusing if indentation
    Date
    From: Julia Lawall <julia@diku.dk>

    Outdent the code following the if.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @r disable braces4@
    position p1,p2;
    statement S1,S2;
    @@

    (
    if (...) { ... }
    |
    if (...) S1@p1 S2@p2
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    if (p1[0].column == p2[0].column):
    cocci.print_main("branch",p1)
    cocci.print_secs("after",p2)
    // </smpl>

    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <Pine.LNX.4.64.1008052227330.31692@ask.diku.dk>
    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-timechart.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
    index 5161619..9bcc38f 100644
    --- a/tools/perf/builtin-timechart.c
    +++ b/tools/perf/builtin-timechart.c
    @@ -455,8 +455,8 @@ static void sched_switch(int cpu, u64 timestamp, struct trace_entry *te)
    if (p->current->state != TYPE_NONE)
    pid_put_sample(sw->next_pid, p->current->state, cpu, p->current->state_since, timestamp);

    - p->current->state_since = timestamp;
    - p->current->state = TYPE_RUNNING;
    + p->current->state_since = timestamp;
    + p->current->state = TYPE_RUNNING;
    }

    if (prev_p->current) {
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2010-08-06 03:51    [W:0.032 / U:0.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site