lkml.org 
[lkml]   [2010]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 53/67] serial: fix missing bit coverage of ASYNC_FLAGS
    Date
    From: John Villalovos <jvillalo@redhat.com>

    It seems that currently ASYNC_FLAGS is one bit short of covering all the
    bits of the ASYNC user flags. In particular it does not cover the
    ASYNC_AUTOPROBE bit.

    ASYNCB_LAST_USER and ASYNCB_AUTOPROBE are both equal to 15.

    Therefore:
    ASYNC_AUTOPROBE = 1000 0000 0000 0000
    ASYNC_FLAGS = 0111 1111 1111 1111

    So ASYNC_FLAGS is not covering the ASYNC_AUTOPROBE bit.

    This patch fixes the issue and with the patch the values will be:
    ASYNC_AUTOPROBE = 1000 0000 0000 0000
    ASYNC_FLAGS = 1111 1111 1111 1111

    As a side note, doing a "git grep" I didn't find any use of
    ASYNC_AUTOPROBE or ASYNCB_AUTOPROBE in the kernel, besides this include
    file.

    Signed-off-by: John Villalovos <john.l.villalovos@intel.com>
    Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    include/linux/serial.h | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/include/linux/serial.h b/include/linux/serial.h
    index c8613c3..c3b45ad 100644
    --- a/include/linux/serial.h
    +++ b/include/linux/serial.h
    @@ -151,7 +151,7 @@ struct serial_uart_config {
    #define ASYNC_BUGGY_UART (1U << ASYNCB_BUGGY_UART)
    #define ASYNC_AUTOPROBE (1U << ASYNCB_AUTOPROBE)

    -#define ASYNC_FLAGS ((1U << ASYNCB_LAST_USER) - 1)
    +#define ASYNC_FLAGS ((1U << (ASYNCB_LAST_USER + 1)) - 1)
    #define ASYNC_USR_MASK (ASYNC_SPD_HI|ASYNC_SPD_VHI| \
    ASYNC_CALLOUT_NOHUP|ASYNC_SPD_SHI|ASYNC_LOW_LATENCY)
    #define ASYNC_SPD_CUST (ASYNC_SPD_HI|ASYNC_SPD_VHI)
    --
    1.7.2


    \
     
     \ /
      Last update: 2010-08-06 00:29    [W:0.021 / U:152.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site