lkml.org 
[lkml]   [2010]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 16/42] net/ipv6/netfilter: Adjust confusing if indentation
    From: Julia Lawall <julia@diku.dk>

    Indent the branch of an if.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @r disable braces4@
    position p1,p2;
    statement S1,S2;
    @@

    (
    if (...) { ... }
    |
    if (...) S1@p1 S2@p2
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    if (p1[0].column == p2[0].column):
    cocci.print_main("branch",p1)
    cocci.print_secs("after",p2)
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
    index 1df3c8b..befccff 100644
    --- a/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
    +++ b/net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c
    @@ -192,7 +192,7 @@ icmpv6_error(struct net *net, struct nf_conn *tmpl,
    icmp6h = skb_header_pointer(skb, dataoff, sizeof(_ih), &_ih);
    if (icmp6h == NULL) {
    if (LOG_INVALID(net, IPPROTO_ICMPV6))
    - nf_log_packet(PF_INET6, 0, skb, NULL, NULL, NULL,
    + nf_log_packet(PF_INET6, 0, skb, NULL, NULL, NULL,
    "nf_ct_icmpv6: short packet ");
    return -NF_ACCEPT;
    }

    \
     
     \ /
      Last update: 2010-08-05 22:25    [W:0.024 / U:0.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site