Messages in this thread | | | From | Axel Lin <> | Date | Thu, 5 Aug 2010 22:22:13 +0800 | Subject | Re: [PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write() |
| |
hi Mark,
2010/8/5 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Thu, Aug 05, 2010 at 11:40:38AM +0800, Axel Lin wrote: >> i2c_smbus_write_byte_data() returns zero or negative value, >> therefore no need to check if ret is greater than zero or not. > >> Signed-off-by: Axel Lin <axel.lin@gmail.com> > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > > but can I once more renew my request that you make some effort to > provide subject lines for your patches which are consistent with the > standard used for the area of the kernel you're submitting to? >
I think we have communication problem. I thought the subject "[PATCH 1/2] lp3971: remove unnecessary ret value checking in lp3971_i2c_write()" is pretty clear. Or do you mean something else?
Regards, Axel
| |