lkml.org 
[lkml]   [2010]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9] v4 Add mutex for add/remove of memory blocks
On Tue, 03 Aug 2010 08:39:50 -0500
Nathan Fontenot <nfont@austin.ibm.com> wrote:

> Add a new mutex for use in adding and removing of memory blocks. This
> is needed to avoid any race conditions in which the same memory block could
> be added and removed at the same time.
>
> Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

But a nitpick (see below)

> ---
> drivers/base/memory.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> Index: linux-2.6/drivers/base/memory.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/memory.c 2010-08-02 13:35:00.000000000 -0500
> +++ linux-2.6/drivers/base/memory.c 2010-08-02 13:45:34.000000000 -0500
> @@ -27,6 +27,8 @@
> #include <asm/atomic.h>
> #include <asm/uaccess.h>
>
> +static struct mutex mem_sysfs_mutex;
> +

For static symbol of mutex, we usually do
static DEFINE_MUTEX(mem_sysfs_mutex);

Then, extra calls of mutex_init() is not required.



\
 
 \ /
  Last update: 2010-08-05 07:01    [W:0.063 / U:21.700 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site