Messages in this thread | | | Subject | Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader. | From | Maxim Levitsky <> | Date | Wed, 04 Aug 2010 19:48:32 +0300 |
| |
On Wed, 2010-08-04 at 00:57 -0700, Alex Dubov wrote: > I see two immediate problems with this patch: > > 1. On cosmetic level, custom debug macros should not be employed. Device > core already have this functionality (dynamic debug levels and such). Please, > use dev_dbg and friends for print-outs. This allows much easier control for debug. Single module parameter is enough to adjust it. This helps me help users. (Eg, kernel compilation is out of question)
> > 2. On a structural level, I'd rather prefer host drivers to not start their > own threads. If you look at both current host implementations, they operate > in callback fashion. Apart from saving some resources, this reduces the > amount of problems encountered during suspend/resume and shutdown. This isn't possible. Hardware doesn't support interrupts on memstick bus changes, it only supports DMA done from/to internal FIFO, and DMA it only possible for 512 byte TPCs.
Best regards, Maxim Levitsky
| |