lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] memcg: generic file stat accounting interface
    On Wed, 25 Aug 2010 17:11:40 +0900
    KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

    > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    >
    > Preparing for adding new status arounf file caches.(dirty, writeback,etc..)
    > Using a unified macro and more generic names.
    > All counters will have the same rule for updating.
    >
    > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

    Reviewed-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>

    one nitpick.

    > @@ -2042,17 +2031,20 @@ static void __mem_cgroup_commit_charge(s
    > static void __mem_cgroup_move_account(struct page_cgroup *pc,
    > struct mem_cgroup *from, struct mem_cgroup *to, bool uncharge)
    > {
    > + int i;
    > VM_BUG_ON(from == to);
    > VM_BUG_ON(PageLRU(pc->page));
    > VM_BUG_ON(!PageCgroupLocked(pc));
    > VM_BUG_ON(!PageCgroupUsed(pc));
    > VM_BUG_ON(id_to_memcg(pc->mem_cgroup, true) != from);
    >
    > - if (PageCgroupFileMapped(pc)) {
    > + for (i = MEM_CGROUP_FSTAT_BASE; i < MEM_CGROUP_FSTAT_END; ++i) {
    > + if (!test_bit(fflag_idx(MEMCG_FSTAT_IDX(i)), &pc->flags))
    > + continue;
    > /* Update mapped_file data for mem_cgroup */
    It might be better to update this comment too.

    /* Update file-stat data for mem_cgroup */

    or something ?

    Thanks,
    Daisuke Nishimura.


    \
     
     \ /
      Last update: 2010-08-31 06:37    [W:0.020 / U:0.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site