lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
    On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
    > In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
    > in error message.
    >
    > I don't think TMR is a suitable abbreviation for thermal.
    > 1.TMR has been used in IA32 Architectures Software Developer's
    > Manual, and is the abbreviation for Trigger Mode Register.
    > 2.There is not an standard abbreviation "TMR" defined for thermal
    > in IA32 Architectures Software Developer's Manual.
    > 3.Though we could understand it as Thermal Monitor Register, it is
    > easy to be misunderstood as a *TIMER* interrupt also.
    >
    > I think this patch will fix it.
    >
    > Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>

    Reviewed-by: Jean Delvare <khali@linux-fr.org>

    > ---
    > arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > index d9368ee..ba52598 100644
    > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
    >
    > static void unexpected_thermal_interrupt(void)
    > {
    > - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
    > + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
    > smp_processor_id());
    > add_taint(TAINT_MACHINE_CHECK);
    > }


    --
    Jean Delvare


    \
     
     \ /
      Last update: 2010-08-31 08:59    [W:0.022 / U:0.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site