lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 03/10] Use percpu stats

    Hi,

    > Also remove references to removed stats (ex: good_comress).

    I'm getting an oops when running mkfs on zram:

    NIP [d0000000030e0340] .zram_inc_stat+0x58/0x84 [zram]
    [c00000006d58f720] [d0000000030e091c] .zram_make_request+0xa8/0x6a0 [zram]
    [c00000006d58f840] [c00000000035795c] .generic_make_request+0x390/0x434
    [c00000006d58f950] [c000000000357b14] .submit_bio+0x114/0x140
    [c00000006d58fa20] [c000000000361778] .blkdev_issue_discard+0x1ac/0x250
    [c00000006d58fb10] [c000000000361f68] .blkdev_ioctl+0x358/0x7fc
    [c00000006d58fbd0] [c0000000001c1c1c] .block_ioctl+0x6c/0x90
    [c00000006d58fc70] [c0000000001984c4] .do_vfs_ioctl+0x660/0x6d4
    [c00000006d58fd70] [c0000000001985a0] .SyS_ioctl+0x68/0xb0

    Since disksize no longer starts as 0 it looks like we can call
    zram_make_request before the device has been initialised. The patch below
    fixes the immediate problem but this would go away if we move the
    initialisation function elsewhere (as suggested in another thread).

    Signed-off-by: Anton Blanchard <anton@samba.org>
    ---

    Index: powerpc.git/drivers/staging/zram/zram_drv.c
    ===================================================================
    --- powerpc.git.orig/drivers/staging/zram/zram_drv.c 2010-09-01 12:35:14.286515175 +1000
    +++ powerpc.git/drivers/staging/zram/zram_drv.c 2010-09-01 12:35:24.167930504 +1000
    @@ -441,6 +441,12 @@ static int zram_make_request(struct requ
    int ret = 0;
    struct zram *zram = queue->queuedata;

    + if (unlikely(!zram->init_done)) {
    + set_bit(BIO_UPTODATE, &bio->bi_flags);
    + bio_endio(bio, 0);
    + return 0;
    + }
    +
    if (unlikely(!valid_io_request(zram, bio))) {
    zram_inc_stat(zram, ZRAM_STAT_INVALID_IO);
    bio_io_error(bio);

    \
     
     \ /
      Last update: 2010-09-01 05:55    [W:0.033 / U:181.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site