Messages in this thread Patch in this message | | | Date | Wed, 1 Sep 2010 13:41:31 +1000 | From | Anton Blanchard <> | Subject | Re: [PATCH 03/10] Use percpu stats |
| |
Hi Nitin,
> There doesn't seem to be a free_percpu() in the module exit path. Something > like this perhaps?
Sorry, was having other zram issues on ppc64 that prevented me from testing this. Stupid bug, removed the &.
Anton
zram: Free percpu data on module exit.
Signed-off-by: Anton Blanchard <anton@samba.org> ---
Index: powerpc.git/drivers/staging/zram/zram_drv.c =================================================================== --- powerpc.git.orig/drivers/staging/zram/zram_drv.c 2010-08-31 15:15:59.344290847 +1000 +++ powerpc.git/drivers/staging/zram/zram_drv.c 2010-09-01 12:35:02.964893575 +1000 @@ -483,8 +483,7 @@ void zram_reset_device(struct zram *zram xv_destroy_pool(zram->mem_pool); zram->mem_pool = NULL; - /* Reset stats */ - memset(&zram->stats, 0, sizeof(zram->stats)); + free_percpu(zram->stats); zram->disksize = zram_default_disksize(); mutex_unlock(&zram->init_lock);
| |