Messages in this thread | | | Subject | Re: [RFC PATCH 4/9] mce: Add persistent events | From | Steven Rostedt <> | Date | Tue, 31 Aug 2010 20:13:20 -0400 |
| |
On Fri, 2010-08-06 at 16:57 +0200, Peter Zijlstra wrote: > On Fri, 2010-08-06 at 16:25 +0200, Borislav Petkov wrote: > > +static const struct file_operations perf_mce_fops = { > > + .llseek = no_llseek, > > + .open = mce_perf_open, > > + .poll = perf_poll, > > + .unlocked_ioctl = perf_ioctl, > > + .compat_ioctl = perf_ioctl, > > + .mmap = perf_mmap, > > + .fasync = perf_fasync, > > + .release = perf_release, > > +}; > > I'd rather see this part of the persistent bits live in > kernel/perf_event.c, that way you don't need the previous patch either. >
This is part of what I hate about the perf design. The fact that everything needs to be very coupled. I would like the infrastructure to be more flexible.
If this does not work, we should have a better internal API that lets this be done. Otherwise we will have this mce fops in core code that has no business being there.
-- Steve
| |