Messages in this thread | | | Date | Wed, 01 Sep 2010 08:49:10 +0900 | From | Kukjin Kim <> | Subject | RE: [PATCH 3/3] ARM: Samsung S3C: Move/use the S3C common GPIO IRQ type |
| |
Kyungmin Park wrote: > > On Mon, Aug 30, 2010 at 9:09 PM, Kukjin Kim <kgene.kim@samsung.com> wrote: > > Kyungmin Park wrote: > >> > >> From: Kyungmin Park <kyungmin.park@samsung.com> > >> > >> Samsung S3C series have the common GPIO IRQ type for all S3C series. > >> > > I can't agree with your changing name. Why do you want to change the name? > > If you want to move S3C2410_EXTINT_XXX from regs-irqtype.h, just move > > without any changes. > As S5P series change the name conversion. I will also modify the s3c series. > I think that we dont need to change for it. And as you see, there is no difference between S3C2410_XXX and S3C_XXX. > > > > But I'm still thinking why should we move the external interrupt definitions > > to plat/gpio-core.h... > > To use the GPIO interrupt. these definitions are used both external > interrupt and GPIO interrupt.
> > > >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > >> ---
(snip)
> >> > >> +#define S3C_GPIO_LEVEL_LOW (0x00) > >> +#define S3C_GPIO_LEVEL_HIGH (0x01) > >> +#define S3C_GPIO_EDGE_FALLING (0x02) > >> +#define S3C_GPIO_EDGE_RISING (0x04) > >> +#define S3C_GPIO_EDGE_BOTH (0x06) > >> + > > GPIO_LELVEL? GPIO_EDGE?... > > > > I think EXTINT_LEVEL_XXX and EXTINT_EDGE_XXX are more clear. > > case IRQ_TYPE_EDGE_BOTH: > newvalue = S3C_GPIO_EDGE_BOTH; > > Don't you it's more clear? > I don't think so, I meant that it is used for external interrupt not gpio. And it used currently for external interrupt.
So, I said that no need to change it now.
Thanks.
Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |