lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] cgroup: do ID allocation under css allocator.
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2010-08-26 09:13:46]:

> On Wed, 25 Aug 2010 19:45:00 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2010-08-25 17:06:40]:
> >
> > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > >
> > > Now, css'id is allocated after ->create() is called. But to make use of ID
> > > in ->create(), it should be available before ->create().
> > >
> > > In another thinking, considering the ID is tightly coupled with "css",
> > > it should be allocated when "css" is allocated.
> > > This patch moves alloc_css_id() to css allocation routine. Now, only 2 subsys,
> > > memory and blkio are useing ID. (To support complicated hierarchy walk.)
> > ^^^^ typo
> > >
> > > ID will be used in mem cgroup's ->create(), later.
> > >
> > > Note:
> > > If someone changes rules of css allocation, ID allocation should be moved too.
> > >
> >
> > What rules? could you please elaborate?
> >
> See Paul Menage's mail. He said "allocating css object under kernel/cgroup.c
> will make kernel/cgroup.c cleaner." But it seems too big for my purpose.
>
> > Seems cleaner, may be we need to update cgroups.txt?
>
> Hmm. will look into.
>

OK, the patch looks good to me otherwise


Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>


--
Three Cheers,
Balbir


\
 
 \ /
  Last update: 2010-08-31 08:35    [W:0.049 / U:1.596 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site