lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues
On Fri, Aug 20, 2010 at 05:00:13PM -0400, T Dent wrote:
> >From 73dfcd936fcacb6f1dce184e21b177c9fa4797d5 Mon Sep 17 00:00:00 2001
> From: Tracey Dent <Tdent48227@gmail.com>
> Date: Thu, 19 Aug 2010 16:13:48 -0400
> Subject: [PATCH 1/8] Staging: rtl8187se: r8180: fixed alot checkpatch.pl issues
>
> Fixed numerous coding style issues using checkpatch.pl
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> ---
> drivers/staging/rtl8187se/r8180.h | 537 ++++++++++++++++++-------------------
> 1 files changed, 265 insertions(+), 272 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180.h
> b/drivers/staging/rtl8187se/r8180.h
> index d15bdf6..c5b1cba 100644
> --- a/drivers/staging/rtl8187se/r8180.h
> +++ b/drivers/staging/rtl8187se/r8180.h
> @@ -1,18 +1,18 @@
> /*
> - This is part of rtl8180 OpenSource driver.
> - Copyright (C) Andrea Merello 2004-2005 <andreamrl@tiscali.it>
> - Released under the terms of GPL (General Public Licence)
> + This is part of rtl8180 OpenSource driver.
> + Copyright (C) Andrea Merello 2004-2005 <andreamrl@tiscali.it>
> + Released under the terms of GPL (General Public Licence)
>
> - Parts of this driver are based on the GPL part of the
> - official realtek driver
> + Parts of this driver are based on the GPL part of the
> + official realtek driver
>
> - Parts of this driver are based on the rtl8180 driver skeleton
> - from Patric Schenke & Andres Salomon
> + Parts of this driver are based on the rtl8180 driver skeleton
> + from Patric Schenke & Andres Salomon
>
> - Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
> + Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver
>
> - We want to tanks the Authors of those projects and the Ndiswrapper
> - project Authors.
> + We want to tanks the Authors of those projects and the Ndiswrapper
> + project Authors.
> */
>
> #ifndef R8180H
> @@ -20,13 +20,13 @@
>
>
> #define RTL8180_MODULE_NAME "r8180"
> -#define DMESG(x,a...) printk(KERN_INFO RTL8180_MODULE_NAME ": " x "\n", ## a)
> -#define DMESGW(x,a...) printk(KERN_WARNING RTL8180_MODULE_NAME ":
> WW:" x "\n", ## a)

Your patches are line-wrapped and can't be applied :(

Care to fix your email client and resend them?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-09-01 00:41    [W:0.061 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site