lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/20] powerpc: Use call_rcu_sched() for pagetables
    From
    Date
    On Sat, 2010-08-28 at 16:16 +0200, Peter Zijlstra wrote:
    > plain text document attachment (powerpc-pgtable-call_rcu_sched.patch)
    > PowerPC relies on IRQ-disable to guard against RCU quiecent states,
    > use the appropriate RCU call version.
    >
    > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    > Cc: Nick Piggin <npiggin@suse.de>
    > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

    So as per discussions with Paul Mck, that should be correct,
    thus

    Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    > ---
    > arch/powerpc/mm/pgtable.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > Index: linux-2.6/arch/powerpc/mm/pgtable.c
    > ===================================================================
    > --- linux-2.6.orig/arch/powerpc/mm/pgtable.c
    > +++ linux-2.6/arch/powerpc/mm/pgtable.c
    > @@ -92,7 +92,7 @@ static void pte_free_rcu_callback(struct
    >
    > static void pte_free_submit(struct pte_freelist_batch *batch)
    > {
    > - call_rcu(&batch->rcu, pte_free_rcu_callback);
    > + call_rcu_sched(&batch->rcu, pte_free_rcu_callback);
    > }
    >
    > void pgtable_free_tlb(struct mmu_gather *tlb, void *table, unsigned shift)
    >
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/




    \
     
     \ /
      Last update: 2010-08-31 08:15    [W:0.023 / U:0.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site