lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/6 v2] HID: magicmouse: Adjust major / minor axes to scale
    Date
    From: Henrik Rydberg <rydberg@euromail.se>

    By visual inspection, the reported touch_major and touch_minor axes
    are roughly a factor of four too small. The factor is approximate,
    since the protocol is not known and the HID report encodes touch size
    with fewer bits than positions. This patch scales the reported values
    by a factor of four.

    Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
    Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
    Acked-by: Michael Poole <mdpoole@troilus.org>
    ---
    drivers/hid/hid-magicmouse.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
    index 364556a..898d0b8 100644
    --- a/drivers/hid/hid-magicmouse.c
    +++ b/drivers/hid/hid-magicmouse.c
    @@ -253,8 +253,8 @@ static void magicmouse_emit_touch(struct magicmouse_sc *msc, int raw_id, u8 *tda
    /* Generate the input events for this touch. */
    if (report_touches && down) {
    input_report_abs(input, ABS_MT_TRACKING_ID, id);
    - input_report_abs(input, ABS_MT_TOUCH_MAJOR, touch_major);
    - input_report_abs(input, ABS_MT_TOUCH_MINOR, touch_minor);
    + input_report_abs(input, ABS_MT_TOUCH_MAJOR, touch_major << 2);
    + input_report_abs(input, ABS_MT_TOUCH_MINOR, touch_minor << 2);
    input_report_abs(input, ABS_MT_ORIENTATION, orientation);
    input_report_abs(input, ABS_MT_POSITION_X, x);
    input_report_abs(input, ABS_MT_POSITION_Y, y);
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-08-31 20:43    [W:2.609 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site