lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] msm: Install the Google-Android gpio driver.
From
Date
On Mon, 2010-08-30 at 17:18 -0700, Gregory Bean wrote:
> + /* printk("%s %08x %08x bit %d gpio %d irq %d\n",
> + __func__, v, m, j, msm_chip->chip.start + j,
> + FIRST_GPIO_IRQ + msm_chip->chip.start + j); */
>

Can you drop everything that's un-used .. There's also the enter/exit
sleep functions, which I'm pretty sure aren't used. Also break this into
two patches one for gpio and another for the interrupt component ..

Daniel

--

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.



\
 
 \ /
  Last update: 2010-08-31 18:53    [W:0.090 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site