lkml.org 
[lkml]   [2010]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/mm] x86, kmemcheck: Remove double test
    Commit-ID:  9fbaf49c7f717740002d49eee1bbd03d89d8766a
    Gitweb: http://git.kernel.org/tip/9fbaf49c7f717740002d49eee1bbd03d89d8766a
    Author: Julia Lawall <julia@diku.dk>
    AuthorDate: Sat, 28 Aug 2010 17:41:03 +0200
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Mon, 30 Aug 2010 09:19:28 +0200

    x86, kmemcheck: Remove double test

    The opcodes 0x2e and 0x3e are tested for in the first Group 2
    line as well.

    The sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @expression@
    expression E;
    @@

    (
    * E
    || ... || E
    |
    * E
    && ... && E
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>
    Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
    Cc: Vegard Nossum <vegardno@ifi.uio.no>
    LKML-Reference: <1283010066-20935-5-git-send-email-julia@diku.dk>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    arch/x86/mm/kmemcheck/opcode.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/mm/kmemcheck/opcode.c b/arch/x86/mm/kmemcheck/opcode.c
    index 63c19e2..324aa3f 100644
    --- a/arch/x86/mm/kmemcheck/opcode.c
    +++ b/arch/x86/mm/kmemcheck/opcode.c
    @@ -9,7 +9,7 @@ static bool opcode_is_prefix(uint8_t b)
    b == 0xf0 || b == 0xf2 || b == 0xf3
    /* Group 2 */
    || b == 0x2e || b == 0x36 || b == 0x3e || b == 0x26
    - || b == 0x64 || b == 0x65 || b == 0x2e || b == 0x3e
    + || b == 0x64 || b == 0x65
    /* Group 3 */
    || b == 0x66
    /* Group 4 */

    \
     
     \ /
      Last update: 2010-08-30 10:41    [W:0.025 / U:0.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site