Messages in this thread | | | Date | Mon, 30 Aug 2010 11:20:18 -0700 | Subject | Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchical scheduling support | From | Chad Talbott <> |
| |
On Sun, Aug 29, 2010 at 11:50 PM, Gui Jianfeng <guijianfeng@cn.fujitsu.com> wrote: > o Each cfq group has its own group service tree. > o Each cfq group contains a "group schedule entity" (gse) that > schedules on parent cfq group's service tree. > o Each cfq group contains a "queue schedule entity"(qse), it > represents all cfqqs located on this cfq group. It schedules > on this group's service tree. For the time being, root group > qse's weight is 1000, and subgroup qse's weight is 500. > o All gses and qse which belones to a same cfq group schedules > on the same group service tree.
Overall, I like this approach. It's similar to what we are using with earlier hierarchical patches. Can you improve the naming a little bit? "qse" and "gse" look almost identical and breaks my brain. Maybe "queue_entity" and "group_entity"? If entity is to much to type, then "item"?
Chad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |