Messages in this thread | | | Date | Tue, 3 Aug 2010 15:43:41 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] flex_array: add helpers to get and put to make pointers easy to use |
| |
On Tue, 3 Aug 2010, Eric Paris wrote:
> > > Getting and putting arrays of pointers with flex arrays is a PITA. You > > > have to remember to pass &ptr to the _put and you have to do weird and > > > wacky casting to get the ptr back from the _get. Add two functions > > > flex_array_get_ptr() and flex_array_put_ptr() to handle all of the magic. > > > > > > > There's no code currently in the tree that uses the flex array interface, > > so is this something that you've encountered in practice or only by > > inspection? If it's the former, is that code on its way for 2.6.36? > > I did decide to use flex_arrays on code intended for .36 > http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=commitdiff;h=6371dcd36f649d9d07823f31400618155a20dde1 >
Great, a user! I'm hoping that more people will adopt this interface but I can't think of anything that could currently be converted. Maybe we can find opportunities in patches as they're proposed to the list.
Thanks.
| |